Skip to content

Linear elasticity 1D #2580

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Linear elasticity 1D #2580

wants to merge 28 commits into from

Conversation

@DanielDoehring
Copy link
Member

@DanielDoehring DanielDoehring commented Sep 24, 2025 •
edited
Loading

Convergence test:

####################################################################################################
l2
v                   sigma               
error     EOC       error     EOC       
7.21e-04  -         8.04e-04  -         
4.01e-05  4.17      3.76e-05  4.42      
2.42e-06  4.05      2.21e-06  4.09      
1.50e-07  4.01      1.36e-07  4.02      
9.35e-09  4.00      8.46e-09  4.01      
5.84e-10  4.00      5.28e-10  4.00      
3.65e-11  4.00      3.30e-11  4.00      
2.28e-12  4.00      2.06e-12  4.00      

mean      4.03      mean      4.08      
----------------------------------------------------------------------------------------------------
linf
v                   sigma               
error     EOC       error     EOC       
1.15e-03  -         3.25e-03  -         
6.19e-05  4.22      1.87e-04  4.12      
4.21e-06  3.88      1.11e-05  4.08      
2.78e-07  3.92      6.72e-07  4.04      
1.78e-08  3.96      4.14e-08  4.02      
1.13e-09  3.98      2.57e-09  4.01      
7.09e-11  3.99      1.60e-10  4.01      
4.45e-12  3.99      9.99e-12  4.00      

mean      3.99      mean      4.04      
----------------------------------------------------------------------------------------------------

Impact test

Initial Condition
Screenshot from 2025-09-24 09-58-48

End state
Screenshot from 2025-09-24 09-59-19

xref #921

@DanielDoehring DanielDoehring added enhancement New feature or request example Adding/changing examples (elixirs) labels Sep 24, 2025
@github-actions
Copy link
Contributor

Review checklist

This checklist is meant to assist creators of PRs (to let them know what reviewers will typically look for) and reviewers (to guide them in a structured review process). Items do not need to be checked explicitly for a PR to be eligible for merging.

Purpose and scope

  • The PR has a single goal that is clear from the PR title and/or description.
  • All code changes represent a single set of modifications that logically belong together.
  • No more than 500 lines of code are changed or there is no obvious way to split the PR into multiple PRs.

Code quality

  • The code can be understood easily.
  • Newly introduced names for variables etc. are self-descriptive and consistent with existing naming conventions.
  • There are no redundancies that can be removed by simple modularization/refactoring.
  • There are no leftover debug statements or commented code sections.
  • The code adheres to our conventions and style guide, and to the Julia guidelines.

Documentation

  • New functions and types are documented with a docstring or top-level comment.
  • Relevant publications are referenced in docstrings (see example for formatting).
  • Inline comments are used to document longer or unusual code sections.
  • Comments describe intent ("why?") and not just functionality ("what?").
  • If the PR introduces a significant change or new feature, it is documented in NEWS.md with its PR number.

Testing

  • The PR passes all tests.
  • New or modified lines of code are covered by tests.
  • New or modified tests run in less then 10 seconds.

Performance

  • There are no type instabilities or memory allocations in performance-critical parts.
  • If the PR intent is to improve performance, before/after time measurements are posted in the PR.

Verification

  • The correctness of the code was verified using appropriate tests.
  • If new equations/methods are added, a convergence test has been run and the results
    are posted in the PR.

Created with ❤️ by the Trixi.jl community.

@codecov
Copy link

codecov bot commented Sep 24, 2025 •
edited
Loading

Codecov Report

❌ Patch coverage is 96.29630% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 96.80%. Comparing base (0cda8ef) to head (7b0c014).

Files with missing lines Patch % Lines
src/equations/linear_elasticity_1d.jl 95.56% 2 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #2580      +/-   ##
==========================================
- Coverage   96.80%   96.80%   -0.00%     
==========================================
  Files         530      532       +2     
  Lines       42682    42736      +54     
==========================================
+ Hits        41317    41369      +52     
- Misses       1365     1367       +2
Flag Coverage Δ
unittests 96.80% <96.30%> (-<0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

DanielDoehring and others added 16 commits September 24, 2025 11:55
ranocha
ranocha requested changes Sep 30, 2025
View reviewed changes
Copy link
Member

@ranocha ranocha left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Please find below some suggestions.

src/equations/linear_elasticity_1d.jl
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some unit tests (checking also Float32 etc.) for the new methods?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you please add some tests to https://github.com/trixi-framework/Trixi.jl/blob/main/test/test_unit.jl and https://github.com/trixi-framework/Trixi.jl/blob/main/test/test_type.jl?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@ranocha ranocha ranocha requested changes

@Arpit-Babbar Arpit-Babbar Awaiting requested review from Arpit-Babbar

Requested changes must be addressed to merge this pull request.

Assignees

No one assigned

Labels

enhancement New feature or request example Adding/changing examples (elixirs)

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@DanielDoehring @ranocha